UI to allow user to load a Youtube video #10

New Issue

rob · 2021-12-14T19:15:24Z

rob commented

2021-12-14 19:15:24 +00:00

First step is probably a text field which allows a Youtube URL or ID to be pasted, with a submit button. Upon submit, the video is loaded.

May need simple router implementation?

First step is probably a text field which allows a Youtube URL or ID to be pasted, with a submit button. Upon submit, the video is loaded. May need simple router implementation?

rob added the

frontend

enhancement

labels 2021-12-14 19:15:34 +00:00

michaelrevans commented

2022-01-01 21:26:53 +00:00

Hi @rob, I'd like to contribute here.

I agree it seems like a good time to add some routing. This feature would be a good entrypoint for the application, so it makes sense to me for this screen to be on /, and then on submission redirecting to /playback?video_id=... - I'm not sure about the route, though, since it's still not clear to me what can be done.

Perhaps /clip or /video or something more generic would be approriate? Open to feedback on this one. Of course, it's easy to change, so not necessary to set it in stone just yet.

Whatever the case, my suggestion would be to introduce react-router-dom, which is pretty much standard for this sort of routing/navigation.

Hi @rob, I'd like to contribute here. I agree it seems like a good time to add some routing. This feature would be a good entrypoint for the application, so it makes sense to me for this screen to be on `/`, and then on submission redirecting to `/playback?video_id=...` - I'm not sure about the route, though, since it's still not clear to me what can be done. Perhaps `/clip` or `/video` or something more generic would be approriate? Open to feedback on this one. Of course, it's easy to change, so not necessary to set it in stone just yet. Whatever the case, my suggestion would be to introduce `react-router-dom`, which is pretty much standard for this sort of routing/navigation.

michaelrevans commented

2022-01-02 07:36:42 +00:00

unstyled proof of concept PR here: #15

unstyled proof of concept PR here: https://git.netflux.io/rob/clipper/pulls/15

rob commented

2022-01-02 11:41:34 +00:00

This all sounds great.

About the naming, there are a lot of unresolved questions with naming in general at the moment (on both the backend and frontend). As a starting point /video/:id would seem to make sense from a user's perspective but as you say it'll be easy to change later.

This all sounds great. About the naming, there are a lot of unresolved questions with naming in general at the moment (on both the backend and frontend). As a starting point `/video/:id` would seem to make sense from a user's perspective but as you say it'll be easy to change later.

👍 1

Sign in to join this conversation.