fixup! wip: refactor: API
This commit is contained in:
parent
aa6f50715d
commit
116623f386
@ -89,8 +89,11 @@ func (a *App) Run(ctx context.Context) error {
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
log.Fatalf("failed to listen: %v", err)
|
log.Fatalf("failed to listen: %v", err)
|
||||||
}
|
}
|
||||||
|
defer lis.Close()
|
||||||
|
|
||||||
grpcServer := grpc.NewServer()
|
grpcServer := grpc.NewServer()
|
||||||
grpcDone := make(chan error, 1)
|
grpcDone := make(chan error, 1)
|
||||||
|
|
||||||
pb.RegisterInternalAPIServer(grpcServer, server.New(a.DispatchAsync, a.eventBus, a.logger))
|
pb.RegisterInternalAPIServer(grpcServer, server.New(a.DispatchAsync, a.eventBus, a.logger))
|
||||||
go func() {
|
go func() {
|
||||||
a.logger.Info("gRPC server started", "addr", grpcAddr)
|
a.logger.Info("gRPC server started", "addr", grpcAddr)
|
||||||
|
@ -132,13 +132,14 @@ func testIntegration(t *testing.T, mediaServerConfig config.MediaServerSource) {
|
|||||||
wg.Add(1)
|
wg.Add(1)
|
||||||
go func() {
|
go func() {
|
||||||
defer wg.Done()
|
defer wg.Done()
|
||||||
assert.NoError(t, client.Run(ctx))
|
assert.ErrorIs(t, server.Run(ctx), context.Canceled)
|
||||||
}()
|
}()
|
||||||
|
|
||||||
wg.Add(1)
|
wg.Add(1)
|
||||||
go func() {
|
go func() {
|
||||||
defer wg.Done()
|
defer wg.Done()
|
||||||
assert.NoError(t, server.Run(ctx))
|
// May be a gRPC error, not context.Canceled:
|
||||||
|
assert.ErrorContains(t, client.Run(ctx), "context canceled")
|
||||||
}()
|
}()
|
||||||
|
|
||||||
require.EventuallyWithT(
|
require.EventuallyWithT(
|
||||||
|
@ -37,6 +37,7 @@ func NewApp(
|
|||||||
bus: event.NewBus(logger),
|
bus: event.NewBus(logger),
|
||||||
clipboardAvailable: clipboardAvailable,
|
clipboardAvailable: clipboardAvailable,
|
||||||
buildInfo: buildInfo,
|
buildInfo: buildInfo,
|
||||||
|
screen: screen,
|
||||||
logger: logger,
|
logger: logger,
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@ -76,7 +76,7 @@ func (s *Server) Communicate(stream pb.InternalAPI_CommunicateServer) error {
|
|||||||
})
|
})
|
||||||
|
|
||||||
if err := g.Wait(); err != nil && !errors.Is(err, io.EOF) && !errors.Is(err, context.Canceled) {
|
if err := g.Wait(); err != nil && !errors.Is(err, io.EOF) && !errors.Is(err, context.Canceled) {
|
||||||
s.logger.Error("Error in gRPC stream handler, exiting", "err", err)
|
s.logger.Error("Client stream closed with error", "err", err)
|
||||||
return fmt.Errorf("errgroup.Wait: %w", err)
|
return fmt.Errorf("errgroup.Wait: %w", err)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Loading…
x
Reference in New Issue
Block a user