- Now `nvim_lsp` source shows diagnostics generated by vim.lsp only
avoids uses vim.diagnostic to avoid deprecation warning on nvim 0.6+
Why? `vim.lsp.diagnostic` deprecation warnings are way too aggressive.
And I'm annoyed by people complaining here even though the warning is
generated by some other plugin (After introduction of nvim_diagnostic
source lualine just can't produce that warning it used to switch users
to nvim_diagnostic source with a warning on nvim0.6+).
Forget it just let anyone that wants lsp specific diagnostics have
`nvim_lsp` . I'd still recommend using `nvim_diagnostic` over
`nvim_lsp` as diagnostics generayed by plugins like `null-ls` won't
showup in `nvim_lsp`
- Remove remanents of `nvim` diagnostics source.
- includes modified class implementation from https://github.com/rxi/classic/blob/master/classic.lua
- now base component class is created from classic.
- change to how component classes are created.
- Don't overwrite new method to initialize a component.
Overwrite the init method. new is responsible for
creating class object and calling init on it.
Unlike previous new overwrite you don't need to create
the class (table) and return it. Instead you will recive
the object as self and do required manipulation on that
just like any most other oop langs. Also don't need to
return anything from init. init's job is to initialize.
remember to call classes init before running your operations
unfortunately lua isn't full fledged oop lang and I don't
how to automate this.
- changes how super classes are accesed.
- rename Component._parent -> Component.super
- methods on super classes now ran through super class instead
of objects _parent self._parent as that can lead to recursive inf loop.
See branch, diff, tabs, buffer classes call to init for example
on pattern.
- All components updated to reflect current logic
- component loader updated to use new initialization procedure.
- updated tests
- updated BREAKING_CHANGES.md
- plus quite a bit of formatting changes in the components
- comp.method = function(self, ...) -> function M:method(...)
BREAKING_CHANGE
shadmansaleh
Jim Tittsler